Add __future__ import style checker #1898
Conversation
|
Hmm, I'm not sure why Travis is refusing to run on my most recent commit to this branch 😢. Looking at the requests page, it seems that fe835a1 was ignored because the branch is "not included or excluded", and this has "overridden" the fact that it is a change PR and should have been built as a change to a PR. |
|
That's weird! Sometimes I really don't understand Travis. |
|
Travis seems to have passed? |
|
I think you're just seeing AppVeyor (the Windows CI), which is a no-op for now. |
This adds the [flake8-future-import][f] plugin for flake8, which enforces the standard set of `__future__` imports at the top of all Python files. This revealed a fair number of files that need to be fixed. To be revisited after #1887 is merged. [f]: https://github.com/xZise/flake8-future-import
|
I rebased this, and added the missing imports. There was only one further line to change slightly, and the tests run fine. However I don't know how github will react if force-pushing this to beetbox/flake8-future-import. Will this be fine, or is it better to open a new PR from a distinct branch? |
|
Thanks, @wordofglass! In my experience, it's fine to force-push to the branch associated with a PR—it will just replace the commits currently listed here. The UI is a little confusing, but it works. |
|
Ok, let's hope that I don't break things 😟 |
wisp3rwind
force-pushed
the
flake8-future-import
branch
from
fe835a1
to
0f89f17
Compare
|
It worked! The commits list moved farther down in the thread visually, but everything worked. 🚀 |
This adds the flake8-future-import plugin for flake8, which enforces the standard set of
__future__imports at the top of all Python files. This revealed a fair number of files that need to be fixed.To be revisited after #1887 is merged.