Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an entry to replace to lookout for paths that begin with "-" #549

Closed
dfc opened this issue Feb 18, 2014 · 2 comments
Closed

Add an entry to replace to lookout for paths that begin with "-" #549

dfc opened this issue Feb 18, 2014 · 2 comments
Labels
feature features we would like to implement good first issue https://github.com/beetbox/beets/pull/5479

Comments

@dfc
Copy link

dfc commented Feb 18, 2014

When I was looking at the replace config for another bug I realized that there was no entry for '^-'. In light of the other defaults and the subsequent explanations it seems that looking out for pathnames that begin with a dash is a good candidate for inclusion. I looked and I did not find anything in my modest music collection but it does not mean its impossible.

Nobody likes this:


dfc@ronin:/tmp/BeetsIsAwesome$ ls -l
total 8
drwxr-xr-x 2 dfc dfc 4096 Feb 17 22:35 Artist One
drwxr-xr-x 2 dfc dfc 4096 Feb 17 22:36 -Artist Two
dfc@ronin:/tmp/BeetsIsAwesome$ cd -Artist\ Two/
-bash: cd: -A: invalid option
cd: usage: cd [-L|[-P [-e]]] [dir]
dfc@ronin:/tmp/BeetsIsAwesome$

I realize that there are ways around this (cd -- -ArtistTwo) but it is minor inconvenience / interruption in normal command line work flow. The default replace setting just needs an additional line;

'^-': _
@sampsyo
Copy link
Member

sampsyo commented Feb 18, 2014

Seems like a great idea to me. Can I convince you to do a pull request with:

  • that proposed one-line change
  • a changelog entry
  • updated docs to reflect the new defaults

? Thanks!

@sampsyo sampsyo added feature and removed feature labels Feb 18, 2014
@dfc
Copy link
Author

dfc commented Feb 18, 2014

Certainly. I was going to but I thought it would be more of a hassle for you. I just need to pull the latest beets changes.

@sampsyo sampsyo added the good first issue https://github.com/beetbox/beets/pull/5479 label Jan 26, 2016
mattmurch added a commit to mattmurch/beets that referenced this issue Apr 12, 2017
Also updated changelog and docs.

Resolves: beetbox#549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement good first issue https://github.com/beetbox/beets/pull/5479
Projects
None yet
Development

No branches or pull requests

2 participants