Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to match non-audio media fetched from MusicBrainz #2688

Closed
zuzzurro opened this issue Sep 13, 2017 · 7 comments
Closed

Don't try to match non-audio media fetched from MusicBrainz #2688

zuzzurro opened this issue Sep 13, 2017 · 7 comments
Labels
feature features we would like to implement

Comments

@zuzzurro
Copy link

Matching a folder containing all audio files of a MB release made of CD+DVD for instance fails since beets does take into account also the video files.
For instance (1 CD+ 1DVD):
https://musicbrainz.org/release/2775743e-2d9c-4b7f-9baa-1d24dc44c769
https://musicbrainz.org/release/f457c3e1-0d98-4904-9d9e-a085bc5b232b
I imagine the same happens for enhanced CDs with some additional video track.
In general I think the right thing to do is that all media files that are marked as video in MB should not be considered for matching. After all beets currently only deals with audio files.

@pprkut
Copy link
Contributor

pprkut commented Sep 13, 2017

Sounds like #1210 and might be related to #1638

@sampsyo
Copy link
Member

sampsyo commented Sep 13, 2017

Indeed! Let’s track this in #1210.

@sampsyo sampsyo closed this as completed Sep 13, 2017
@nguillaumin
Copy link
Contributor

I think that's actually a slightly different issue that may need separate consideration and re-opening.

#1210 is about having a single (or multiple) non-music tracks inside a given medium, mixed with audio tracks. See track 21 on this - xml

This issue is about skipping a complete medium, for release that have CD+DVD for example. See this - xml

In the later case, the medium to skip is identified by its format of type DVD:

<medium-list count="2">
  <medium>
    <position>1</position>
    <format id="9712d52a-4509-3d4b-a1a2-67c88c643e31">CD</format>
    <track-list count="10" offset="0">...</track-list>
  </medium>
  <medium>
    <position>2</position>
    <format id="2875c583-4580-3a90-b723-ba1b39921e23">DVD</format>
    <track-list offset="0" count="7">...</track-list>
  </medium>
</medium-list>

A list of formats is available here

Currently when trying to import this release, I get:

Tagging:
    Playing for Change - Songs Around the World
URL:
    https://musicbrainz.org/release/1082195b-9b14-466f-a443-7cf830f64316
(Similarity: 84.9%) (missing tracks) (2xCD, 2009, US, Hear Music)
CD 1
Missing tracks (7/17 - 41.2%):
 ! Stand by Me (#11)
 ! One Love (#12)
 ! War / No More Trouble (#13)
 ! Don't Worry (#14)
 ! Chanda Mama (#15)
 ! The Playing for Change Foundation (#16)
 ! Peace Through Music (#17)
[A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort?

@sampsyo
Copy link
Member

sampsyo commented Dec 29, 2017

Ah, I see! So they’re certainly related, but not exactly the same problem. Perhaps #2404 is a closer precedent?

@nguillaumin
Copy link
Contributor

I think that's different too. #2404 is about alternative audio media, like a CD and a DVD-Audio, or a CD and a Digital Media. I think this issue is simpler, it's just about ignoring media that don't contain audio (such as DVD, or CD-Rom (data) disks).

@sampsyo
Copy link
Member

sampsyo commented Dec 29, 2017

Got it; thanks for helping to clarify. I'll reopen this and change the title.

@sampsyo sampsyo reopened this Dec 29, 2017
@sampsyo sampsyo added the feature features we would like to implement label Dec 29, 2017
@sampsyo sampsyo changed the title Skip videos in MB matching Don't try to match non-audio media fetched from MusicBrainz Dec 29, 2017
nguillaumin pushed a commit to nguillaumin/beets that referenced this issue Dec 30, 2017
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip
these media when fetching album info as they will never match audio
tracks and will always report missing tracks.

I took the naive approach of cherry-picking a list of media suspected to
not contain audio from the [MusicBrainz formats
list](https://musicbrainz.org/doc/Release/Format)
nguillaumin pushed a commit to nguillaumin/beets that referenced this issue Dec 30, 2017
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip
these media when fetching album info as they will never match audio
tracks and will always report missing tracks.

I took the naive approach of cherry-picking a list of media suspected to
not contain audio from the MusicBrainz formats list:

https://musicbrainz.org/doc/Release/Format
nguillaumin added a commit to nguillaumin/beets that referenced this issue Dec 30, 2017
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip
these media when fetching album info as they will never match audio
tracks and will always report missing tracks.

I took the naive approach of cherry-picking a list of media suspected to
not contain audio from the MusicBrainz formats list:

https://musicbrainz.org/doc/Release/Format
nguillaumin added a commit to nguillaumin/beets that referenced this issue Dec 30, 2017
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip
these media when fetching album info as they will never match audio
tracks and will always report missing tracks.

I took the naive approach of cherry-picking a list of media suspected to
not contain audio from the MusicBrainz formats list:

https://musicbrainz.org/doc/Release/Format
nguillaumin added a commit to nguillaumin/beets that referenced this issue Dec 30, 2017
Some releases have non-audio media, such as CD+DVD or CD+DVD-Video. Skip
these media when fetching album info as they will never match audio
tracks and will always report missing tracks.

I took the naive approach of cherry-picking a list of media suspected to
not contain audio from the MusicBrainz formats list:

https://musicbrainz.org/doc/Release/Format
sampsyo added a commit that referenced this issue Dec 31, 2017
Fixes #2688: Skip non-audio media from MusicBrainz
@pprkut
Copy link
Contributor

pprkut commented Dec 31, 2017

What would be a good way to make this optional? Boolean flag in the config? Or perhaps making the list of formats configurable?
Maybe there's a way to detect whether the tracks are present and only ignore missing media?
I like tracking audio-only versions of the video tracks with beets and would like to continue doing that

nguillaumin added a commit to nguillaumin/beets that referenced this issue Dec 31, 2017
Users may want to keep tracking video tracks, for example if they rip
the audio part of the video tracks. Added a setting to allow this. This
is related to the beetbox#2688 change.

My impression is that it would be quite rare though so I made the
setting ignore video tracks by default, but that's easily changed if
desired.
nguillaumin added a commit to nguillaumin/beets that referenced this issue Jan 2, 2018
This is related to beetbox#2688 where a list of hard-coded non-audio formats to
ignore has been added. Some users may want to rip the audio portion of
video tracks (e.g. DVD-Video) so it would be beneficial to let them
control exactly which formats to ignore.

I added a `ignored_formats` setting for that purpose and moved the
hard-coded list into the config. Test and documentation have been
updated accordingly.

Aside: I also clarified the changelog a bit regarding this change and
the related one for beetbox#1210.
msjyoo pushed a commit to msjyoo/beets that referenced this issue Jan 4, 2018
This is related to beetbox#2688 where a list of hard-coded non-audio formats to
ignore has been added. Some users may want to rip the audio portion of
video tracks (e.g. DVD-Video) so it would be beneficial to let them
control exactly which formats to ignore.

I added a `ignored_formats` setting for that purpose and moved the
hard-coded list into the config. Test and documentation have been
updated accordingly.

Aside: I also clarified the changelog a bit regarding this change and
the related one for beetbox#1210.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants