Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove the hardcoded httpmethod and update ci tools #647

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: remove the hardcoded httpmethod and update ci tools #647

wants to merge 1 commit into from

Conversation

AlphaWong
Copy link

@AlphaWong AlphaWong commented Jan 20, 2020 •
edited
Loading

use the built-in http method.

http.MethodGet

replace all static check by golangci-lint run -D errcheck

@AlphaWong AlphaWong changed the title refactor: remove the hardcoded httpmethod refactor: remove the hardcoded httpmethod and update ci tools Jan 21, 2020
@askuy
Copy link
Collaborator

askuy commented Jun 23, 2020 •
edited
Loading

we remove vendor and fix go-delve, it cause unable to merge this pr
but we found this pr some are more useful
do you want to create new pr for bee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astaxie astaxie Awaiting requested review from astaxie

@amrfaissal amrfaissal Awaiting requested review from amrfaissal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlphaWong @askuy