Fix Install breaking - Apply more strict rules for activerecord version #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinduolis
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
zinduolis
changed the title
|
Hey @stephenakq , this is a quick one and fixes the kali-help issue a person raised in discord. Please merge it once you're happy. |
koziuri
approved these changes
Nov 3, 2024
Mokres
approved these changes
Nov 3, 2024
zinduolis
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
|
No longer relevant as 7.2 with code refactoring to make it compliant was successfully merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
Bug
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: At this stage beef works with activerecord up to version 7.1.4.2. However, command in Gemfile didn't enforce that and would allow for installation of the latest minor version, which is 7.2.1.2. This happens when person runs ./install.
Q: Give a technical rundown of what you have changed (if applicable)
A: Added strict rule into Gemfile to install the 7.1.4.2 version not to break the installation. As part of dependabot suggested upgrade will analyse the differences in 7.2.1.2 and get them installed in controlled and tested way.
Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: bundle exec rake, running framework and debug modules through FF browser. Also, the Browserstack testing will run as part of this PR check.
Wiki Page
If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.