Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Browserstack testing failure (#3172) #3176

Merged
merged 23 commits into from
Oct 27, 2024

Conversation

zinduolis
Copy link
Collaborator

@zinduolis zinduolis commented Oct 24, 2024

Pull Request

Thanks for submitting a PR! Please fill in this template where appropriate:

Category

*e.g. Bug

Feature/Issue Description

Q: Please give a brief summary of your feature/fix
A: The issue is described here: #3172 (#3172)

Q: Give a technical rundown of what you have changed (if applicable)
A: The root cause was missing activerecord gem and a parameter in ActiverRecord::Migrator (the parameter was added in the latest major version).

Test Cases

Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: Successfully ran bundle exec rake and executed all the debug modules on Chrome without any errors on beef side. Also I've run bundle exec rake browserstack --trace which is starting the. HTTP Hook Server and needs Browserstack credentials to proceed. These credentials are supplied during the github action that runs on PR when it's approved. Thus the last test will be confirmed once this PR is approved.

Wiki Page

If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.

@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 24, 2024 05:16 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 24, 2024 05:29 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 24, 2024 05:40 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 24, 2024 05:45 — with GitHub Actions Failure
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 25, 2024 05:42 — with GitHub Actions Inactive
@zinduolis zinduolis changed the title TEST PR for github actions - DO NOT MERGE Fix Browserstack testing failure (#3172) Oct 25, 2024
@zinduolis zinduolis requested a review from stephenakq October 25, 2024 05:56
@zinduolis
Copy link
Collaborator Author

Hey @stephenakq , please approve this PR, but not merge yet. Thanks

@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 06:03 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 06:13 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 06:27 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 06:33 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 06:37 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 06:42 — with GitHub Actions Inactive
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 06:49 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 06:55 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 08:36 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 08:45 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 08:52 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 08:59 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request October 27, 2024 09:06 — with GitHub Actions Failure
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 09:12 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 09:19 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 09:25 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 09:42 — with GitHub Actions Inactive
@zinduolis zinduolis temporarily deployed to Integrate Pull Request October 27, 2024 09:48 — with GitHub Actions Inactive
@zinduolis
Copy link
Collaborator Author

Hey @stephenakq , this is now fixed. Please merge it. Thanks

@stephenakq stephenakq merged commit 4b926df into beefproject:master Oct 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants