-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Browserstack testing failure (#3172) #3176
Merged
stephenakq
merged 23 commits into
beefproject:master
from
zinduolis:3172_Browserstack_failing
Oct 27, 2024
Merged
Fix Browserstack testing failure (#3172) #3176
stephenakq
merged 23 commits into
beefproject:master
from
zinduolis:3172_Browserstack_failing
Oct 27, 2024
+25
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinduolis
had a problem deploying
to
Integrate Pull Request
October 24, 2024 05:16 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 24, 2024 05:29 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 24, 2024 05:40 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 24, 2024 05:45 — with
GitHub Actions
Failure
Loading status checks…
zinduolis
temporarily deployed
to
Integrate Pull Request
October 25, 2024 05:42 — with
GitHub Actions
Inactive
zinduolis
changed the title
TEST PR for github actions - DO NOT MERGE
Fix Browserstack testing failure (#3172)
Oct 25, 2024
Hey @stephenakq , please approve this PR, but not merge yet. Thanks |
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 06:03 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 06:13 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 06:27 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 06:33 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 06:37 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 06:42 — with
GitHub Actions
Inactive
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 06:49 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 06:55 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 08:36 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 08:45 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 08:52 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 08:59 — with
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
October 27, 2024 09:06 — with
GitHub Actions
Failure
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 09:12 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 09:19 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 09:25 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 09:42 — with
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
October 27, 2024 09:48 — with
GitHub Actions
Inactive
Hey @stephenakq , this is now fixed. Please merge it. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
*e.g. Bug
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: The issue is described here: #3172 (#3172)
Q: Give a technical rundown of what you have changed (if applicable)
A: The root cause was missing activerecord gem and a parameter in ActiverRecord::Migrator (the parameter was added in the latest major version).
Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: Successfully ran bundle exec rake and executed all the debug modules on Chrome without any errors on beef side. Also I've run
bundle exec rake browserstack --trace
which is starting the. HTTP Hook Server and needs Browserstack credentials to proceed. These credentials are supplied during the github action that runs on PR when it's approved. Thus the last test will be confirmed once this PR is approved.Wiki Page
If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.