Rename veganLol and refresh jsdocs (#2040) #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zinduolis
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
zinduolis
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
zinduolis
force-pushed
the
2040_Rename_veganLol
branch
from
f9c74c1 to
078a87f
Compare
zinduolis
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
zinduolis
force-pushed
the
2040_Rename_veganLol
branch
from
078a87f to
189e945
Compare
zinduolis
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
|
Removed fix for beef startup from this PR and created a separate PR for the fix: #3162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
e.g. Bug, Documentation
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: Rename veganLol and refresh jsdocs (#2040)
Q: Give a technical rundown of what you have changed (if applicable)
A: Renamed veganLol function to cookieValueRandomizer() and updated the references in cookie.js. Also, removed redundant comment in browser.js and then regenerated jsdocs to update the references there.
Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: Successfully ran bundle exec rake and then all the debug modules in the framework.
Wiki Page
If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.