Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 0.92.0 to ~> 1.20.0 #2154

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2021

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.20

New features

Bug fixes

  • #10033: Fix an incorrect auto-correct for Style/BlockDelimiters when there is a comment after the closing brace and using method chanin. (@​koic)
  • #6630: Updated Style/CommentAnnotation to be able to handle multiword keyword phrases. (@​dvandersluis)
  • #7836: Update Style/BlockDelimeters to add begin...end when converting a block containing rescue or ensure to braces. (@​dvandersluis)
  • #10031: Fix a false positive for Style/HashExcept when comparing with hash value. (@​koic)

Changes

Changelog

Sourced from rubocop's changelog.

1.20.0 (2021-08-26)

New features

Bug fixes

  • #10033: Fix an incorrect auto-correct for Style/BlockDelimiters when there is a comment after the closing brace and using method chanin. ([@​koic][])
  • #6630: Updated Style/CommentAnnotation to be able to handle multiword keyword phrases. ([@​dvandersluis][])
  • #7836: Update Style/BlockDelimeters to add begin...end when converting a block containing rescue or ensure to braces. ([@​dvandersluis][])
  • #10031: Fix a false positive for Style/HashExcept when comparing with hash value. ([@​koic][])

Changes

1.19.1 (2021-08-19)

Bug fixes

  • #10017: Fixan error for Layout/RescueEnsureAlignment when using zsuper with block. ([@​koic][])
  • #10011: Fix a false positive for Style/RedundantSelfAssignmentBranch when using instance variable, class variable, and global variable. ([@​koic][])
  • #10010: Fix a false positive for Style/DoubleNegation when !! is used at return location and before rescue keyword. ([@​koic][])
  • #10014: Fix Style/Encoding to handle more situations properly. ([@​dvandersluis][])
  • #10016: Fix conflict between Style/SoleNestedConditional and Style/NegatedIf/Style/NegatedUnless. ([@​dvandersluis][])
  • #10024: Fix an incorrect auto-correct for Style/RedundantSelfAssignmentBranch when using multiline if / else conditional assignment. ([@​koic][])
  • #10004: Fix a false positive for Style/RedundantBegin when using one-liner with semicolon. ([@​koic][])

1.19.0 (2021-08-12)

New features

  • #4182: Add Lint/AmbiguousRange cop to check for ranges with ambiguous boundaries. ([@​dvandersluis][])
  • #10000: Parallel static analysis by default. ([@​koic][])
  • #9948: Support Ruby 2.7's pattern matching for Style/ConditionalAssignment cop. ([@​koic][])
  • #9999: Add new Style/RedundantSelfAssignmentBranch cop. ([@​koic][])

Bug fixes

  • #9927: Indent hash values in Layout/LineEndStringConcatenationIndentation. ([@​jonas054][])
  • #9959: Make Style/IdenticalConditionalBranches able to handle ternary ifs. ([@​dvandersluis][])
  • #9946: Avoid slow regexp matches in Style/CommentedKeyword. ([@​jonas054][])
  • #7422: Treat constant assignment like other assignment in Layout/SpaceAroundOperators. ([@​dvandersluis][])
  • #9953: Fix an infinite loop error and a false auto-correction behavior for Layout/EndAlignment when using a conditional statement in a method argument. ([@​koic][])
  • #9958: Prevent an infinite loop when a detected method has fewer arguments than expected. ([@​dvandersluis][])

... (truncated)

Commits
  • 536d986 Cut 1.20
  • 6516c18 Update Changelog
  • 60552ea Update a changelog entry
  • baba941 [Fix #9580] Add New Cop to Enforce Bundler Gem filename (#9903)
  • 016838b [Fix #7836] Update Style/BlockDelimeters to add begin...end when conver...
  • 5ad72a1 Clarify relationship between Layout/MultilineMethodArgumentLineBreaks and `...
  • 2bab715 [Fix #6630] Updated Style/CommentAnnotation to be able to handle multiword ...
  • 150f285 Refactor AnnotationComment into an actual class representing an annotation ...
  • 9ff50d1 Make Lint/Debugger aware of debug.rb
  • 7b0358f [Fix #10031] Fix a false positive for Style/HashExcept
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.92.0...v1.20.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests for Ruby compatibility labels Aug 26, 2021
@dependabot dependabot bot requested review from bcoles and jcrew99 August 26, 2021 13:18
@wheatley wheatley requested review from wheatley and DeezyE September 4, 2021 09:36
@wheatley
Copy link
Contributor

wheatley commented Sep 4, 2021

PR

Screen Shot 2021-09-04 at 8 03 30 pm

master branch
Screen Shot 2021-09-04 at 8 05 10 pm

both allow rubocop to run giving the same errors

@wheatley wheatley merged commit 27e58a7 into master Sep 4, 2021
@wheatley wheatley deleted the dependabot/bundler/rubocop-tw-1.20.0 branch September 4, 2021 10:07
@bcoles bcoles added this to the 0.5.2.0-alpha milestone Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests for Ruby compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants