Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop requirement from ~> 0.92.0 to ~> 1.19.0 #2146

Closed
wants to merge 1 commit into from
Closed

Update rubocop requirement from ~> 0.92.0 to ~> 1.19.0 #2146

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2021

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.19

New features

  • #4182: Add Lint/AmbiguousRange cop to check for ranges with ambiguous boundaries. (@​dvandersluis)
  • #10000: Parallel static analysis by default. (@​koic)
  • #9948: Support Ruby 2.7's pattern matching for Style/ConditionalAssignment cop. (@​koic)
  • #9999: Add new Style/RedundantSelfAssignmentBranch cop. (@​koic)

Bug fixes

  • #9927: Indent hash values in Layout/LineEndStringConcatenationIndentation. (@​jonas054)
  • #9959: Make Style/IdenticalConditionalBranches able to handle ternary ifs. (@​dvandersluis)
  • #9946: Avoid slow regexp matches in Style/CommentedKeyword. (@​jonas054)
  • #7422: Treat constant assignment like other assignment in Layout/SpaceAroundOperators. (@​dvandersluis)
  • #9953: Fix an infinite loop error and a false auto-correction behavior for Layout/EndAlignment when using a conditional statement in a method argument. (@​koic)
  • #9958: Prevent an infinite loop when a detected method has fewer arguments than expected. (@​dvandersluis)
  • #9977: Update Layout/EmptyLineAfterGuardClause to not register an offense if there is another expression following the guard clause on the same line. (@​dvandersluis)
  • #9980: Fix a false positive for Style/IdenticalConditionalBranches when assigning to a variable used in a condition. (@​koic)
  • #9975: Parentheses are always required for Style/MethodDefParentheses when a forwarding argument (...) is used. (@​dvandersluis)
  • #9984: Fix false negatives involving heredocs for Layout/SpaceBeforeComma, Layout/SpaceBeforeComment, Layout/SpaceBeforeSemicolon and Layout/SpaceInsideParens. (@​dvandersluis)
  • #9954: Fix infinite loop error for Layout/HashAlignment when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. (@​koic)
  • #10002: Fix an incorrect auto-correct for Lint/AmbigousRegexpLiteral when using nested method arguments without parentheses. (@​koic)
  • #9952 rubocop-rspec#1126: Fix inherit_mode for deeply nested configuration defined in extensions' default configuration. (@​pirj)
  • #9957: Add WholeWord configuration to Naming/InclusiveLanguage's FlaggedTerms config. (@​dvandersluis)
  • #9970: Don't register an offense when sort method has arguments for Style/RedundantSort cop. (@​mtsmfm)
  • #4097: Add require English for special globals. (@​biinari)
  • #9955: Fix Style/ExplicitBlockArgument adding a second set of parentheses. (@​dvandersluis)
  • #9973: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue keyword and leading dot. (@​koic)
  • #9945: Fix auto-correction of lines in heredocs with only spaces in Layout/TrailingWhitespace. (@​jonas054)

Changes

  • #9989: Mark Style/CommentedKeyword as unsafe auto-correction. (@​koic)
  • #9964: Make Layout/LeadingCommentSpace aware of #:nodoc. (@​koic)
  • #9985: Mark Style/IdenticalConditionalBranches as unsafe auto-correction. (@​koic)
  • #9962: Update Style/WordArray to register an offense in percent style if any values contain spaces. (@​dvandersluis)
  • #9979: Enable basic autocorrection for Style/Semicolon. (@​dvandersluis)
Changelog

Sourced from rubocop's changelog.

1.19.0 (2021-08-12)

New features

  • #4182: Add Lint/AmbiguousRange cop to check for ranges with ambiguous boundaries. ([@​dvandersluis][])
  • #10000: Parallel static analysis by default. ([@​koic][])
  • #9948: Support Ruby 2.7's pattern matching for Style/ConditionalAssignment cop. ([@​koic][])
  • #9999: Add new Style/RedundantSelfAssignmentBranch cop. ([@​koic][])

Bug fixes

  • #9927: Indent hash values in Layout/LineEndStringConcatenationIndentation. ([@​jonas054][])
  • #9959: Make Style/IdenticalConditionalBranches able to handle ternary ifs. ([@​dvandersluis][])
  • #9946: Avoid slow regexp matches in Style/CommentedKeyword. ([@​jonas054][])
  • #7422: Treat constant assignment like other assignment in Layout/SpaceAroundOperators. ([@​dvandersluis][])
  • #9953: Fix an infinite loop error and a false auto-correction behavior for Layout/EndAlignment when using a conditional statement in a method argument. ([@​koic][])
  • #9958: Prevent an infinite loop when a detected method has fewer arguments than expected. ([@​dvandersluis][])
  • #9977: Update Layout/EmptyLineAfterGuardClause to not register an offense if there is another expression following the guard clause on the same line. ([@​dvandersluis][])
  • #9980: Fix a false positive for Style/IdenticalConditionalBranches when assigning to a variable used in a condition. ([@​koic][])
  • #9975: Parentheses are always required for Style/MethodDefParentheses when a forwarding argument (...) is used. ([@​dvandersluis][])
  • #9984: Fix false negatives involving heredocs for Layout/SpaceBeforeComma, Layout/SpaceBeforeComment, Layout/SpaceBeforeSemicolon and Layout/SpaceInsideParens. ([@​dvandersluis][])
  • #9954: Fix infinite loop error for Layout/HashAlignment when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. ([@​koic][])
  • #10002: Fix an incorrect auto-correct for Lint/AmbigousRegexpLiteral when using nested method arguments without parentheses. ([@​koic][])
  • #9952 rubocop-rspec#1126: Fix inherit_mode for deeply nested configuration defined in extensions' default configuration. ([@​pirj][])
  • #9957: Add WholeWord configuration to Naming/InclusiveLanguage's FlaggedTerms config. ([@​dvandersluis][])
  • #9970: Don't register an offense when sort method has arguments for Style/RedundantSort cop. ([@​mtsmfm][])
  • #4097: Add require English for special globals. ([@​biinari][])
  • #9955: Fix Style/ExplicitBlockArgument adding a second set of parentheses. ([@​dvandersluis][])
  • #9973: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue keyword and leading dot. ([@​koic][])
  • #9945: Fix auto-correction of lines in heredocs with only spaces in Layout/TrailingWhitespace. ([@​jonas054][])

Changes

  • #9989: Mark Style/CommentedKeyword as unsafe auto-correction. ([@​koic][])
  • #9964: Make Layout/LeadingCommentSpace aware of #:nodoc. ([@​koic][])
  • #9985: Mark Style/IdenticalConditionalBranches as unsafe auto-correction. ([@​koic][])
  • #9962: Update Style/WordArray to register an offense in percent style if any values contain spaces. ([@​dvandersluis][])
  • #9979: Enable basic autocorrection for Style/Semicolon. ([@​dvandersluis][])

1.18.4 (2021-07-23)

New features

  • #9930: Support Ruby 2.7's pattern matching for Lint/DuplicateBranch cop. ([@​koic][])

Bug fixes

  • #9938: Fix an incorrect auto-correct for Layout/LineLength when a heredoc is used as the first element of an array. ([@​koic][])
  • #9940: Fix an incorrect auto-correct for Style/HashTransformValues when value is a hash literal for _.to_h{...}. ([@​koic][])
  • #9752: Improve error message for top level department used in configuration. ([@​jonas054][])

... (truncated)

Commits
  • a6d8d92 Cut 1.19.0
  • 6d44d57 Update Changelog
  • cda3f43 [Fix #9980] Fix a false positive for Style/IdenticalConditionalBranches
  • 6907fa3 [Fix #9962] Update Style/WordArray to register an offense in percent styl...
  • 2fd1221 [Fix #9973] Fix a false positive for Layout/RescueEnsureAlignment
  • b3f6e50 [Fix #4182] Add Lint/AmbiguousRange cop to check for ranges with ambiguous ...
  • 07c8ef8 Add new Style/RedundantSelfAssignmentBranch cop
  • 0d5d736 Add doc and test for about pattern matching for Style/MissingElse
  • 499b3f6 Update StyleGuide URL for Style/WhenThen
  • 4363068 Update the doc for Style/BlockDelimiters
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update rubocop requirement from ~> 0.92.0 to ~> 1.19.0
e725555 
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.92.0...v1.19.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests for Ruby compatibility labels Aug 12, 2021
@dependabot dependabot bot mentioned this pull request Aug 12, 2021
Closed
@wheatley wheatley requested review from bcoles and jcrew99 August 12, 2021 21:21
@wheatley
Copy link
Contributor

@bcoles & @jcrew99 - I think we can merge this even if we don't use rubocop officially.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 19, 2021

Superseded by #2151.

@dependabot dependabot bot closed this Aug 19, 2021
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-tw-1.19.0 branch August 19, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoles bcoles Awaiting requested review from bcoles

@jcrew99 jcrew99 Awaiting requested review from jcrew99

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ruby Pull requests for Ruby compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wheatley