sudo for gem install, ruby package manager check #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works for me with rvm and is a good way to handle there being a ruby version before just installing ruby. It changes a command to sudo but beef runs as root anyway. I feel comfortable merging. Watch out for installation errors that may be related to this though |
This was referenced Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
install script
Feature/Issue Description
The install script now checks for Ruby package managers and will not install ruby if they are present.
Ruby version check takes package manager into account now
Added 'sudo' to the gem install to handle newer Kali 2020 where user is no longer root
Describe what changes
Checks whether rvm or rbenv are being used. Only installs ruby if package manager is NOT present
Relevant wiki page
I don't believe changes need to be made to wiki