Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed how websocket hooked browsers time out #1888

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

grantrburgess
Copy link
Contributor

Fixes a bug where adding a longer timeout for websocket polls causes the browser to show as offline in the ui panel.

@jcrew99
Copy link
Collaborator

jcrew99 commented Apr 2, 2020

@grantrburgess We should get some more test coverage on this, but as is it should be fine to merge.

@jcrew99 jcrew99 merged commit 6ebb8a0 into master Apr 2, 2020
@wheatley wheatley deleted the fixed_offline_browser_bug_when_using_websockets branch September 4, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants