fixing #1851 #1858
Merged
fixing #1851 #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrew99
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
This was added to the wiki and the test seems to have issues run in the travis.ci browser, it works in mine as well as @h4sh5 .
This just needs to be part of the testing suite, or possible changed so travis ignores it possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Bug #1851
Feature/Issue Description
Fixing requester extension not working issue. Mostly fixing active record, but also some interesting bugs in the requester handler
Test cases
spec/beef/extensions/requester_spec.rb
BeefTest.new_victim. It is hooked, then it requests a page and checks if response exists. Takes quite long to run though (~13 seconds)To run the functional test, which is by default skipped, change the
xittoitin front of the definition: (around line 20)Relevant wiki page
https://github.com/beefproject/beef/wiki/Proxy-and-requester-extension