Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor install for #1477 #1518

Merged
merged 13 commits into from
Mar 9, 2018
Merged

Refactor install for #1477 #1518

merged 13 commits into from
Mar 9, 2018

Conversation

0xmachos
Copy link
Contributor

@0xmachos 0xmachos commented Mar 9, 2018

This PR contains no functional changes.

Edit: This is for #1477

I've converted the script to use functions for each major step.

Updated the info, warn and fatal functions to use colour output.

For consistency I wrapped variable expansion in curly braces. e.g "$var1" to "${var1}".

I replaced use of backticks for command output capture with braces. e.g. `whoami` to $(whoami).

I've tested this on Debian 9.3.

@bcoles
Copy link
Collaborator

bcoles commented Mar 9, 2018

Thanks

@bcoles bcoles merged commit acc589f into beefproject:master Mar 9, 2018
@bcoles bcoles self-requested a review March 9, 2018 14:06
@bcoles bcoles self-assigned this Mar 9, 2018
@bcoles
Copy link
Collaborator

bcoles commented Mar 9, 2018

Do you happen to own a Mac?

@bcoles bcoles added the Install label Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants