Add more 'Media' related regexes #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
suggested changes
Jul 13, 2021
amadejpapez
reviewed
Jul 13, 2021
|
Hey! 👋🏻 I'm not sure on how okay I am at providing regex for specific sites when we already have a URL regex, is there any reason you'd want this? 😄 ❤️ |
Mainly just to add more 'media' regexes. The existing 3 YouTube regexes are the only [social] media ones, so similar regexes for other social networks seemed to fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds media related regexes similar to the existing YouTube Video regex, in which they match the URL of something like a social media post.
Includes:
These will match URLs, so for example 'https://twitter.com/jack/status/20/', 'https://reddit.com/r/funny', 'https://discord.com/invite/hTKzmak', etc.