fix(deps): upgrade moment to 2.29.4 #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please @bradvogel when you get some chance |
|
Unfortunately we're not able to review farther fixes in this repo. I filed #546. @roggervalf do you have an interest in being a maintainer? |
|
hey @bradvogel, sure I can |
|
@roggervalf I granted you 'Maintain' access, so you should be able to review PRs from now on. I'll approve this one. |
|
@roggervalf Actually, could we merge #540 instead? We don't need the update to package.json, as it uses the |
|
sure, it should be fine let me close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Upgrade moment to version 2.29.4 ref #540, this one also changes the package in package.json file
Potential Risks
None
Test Plan
As it is a minor change version it should work as expected
Checklist