Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow child one-to-one instances to be updated without providing PK (updated) #36

Merged
merged 1 commit into from Apr 20, 2018

Conversation

karamanolev
Copy link
Contributor

This is an updated version of #29

  • Implemented from current master, so no merge conflicts.
  • Comments/requests for changes from ruscoder implemented.
  • Test updated to pass (with latest master).
  • Tested on our codebase.

We're now using the fork for our project, but I'd love to see this in mainline.

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #36 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   99.36%   99.39%   +0.02%     
==========================================
  Files           3        3              
  Lines         158      165       +7     
==========================================
+ Hits          157      164       +7     
  Misses          1        1
Impacted Files Coverage Δ
drf_writable_nested/mixins.py 99.34% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4ee4b...49be7bd. Read the comment docs.

@karamanolev
Copy link
Contributor Author

@ruscoder Do you think you'll have some time soon to review this?

@ruscoder
Copy link
Member

@karamanolev Thanks for the contribution1 I'll try to review your PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants