-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Customer and Support schema to add new properties #359
Conversation
Hi @ravi-prakash-v, I created a new PR. This has all the changes we discussed. Can you please take a look at it and approve it if everything looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the Customer schema and Agent schema are the same except for being rateable and having a Rating. May be customer should also be rateable. I suggest we derive Customer from Agent.. FulfillmentAgent from Agent, Possibly fulfillment.agent could be of type FulfillmentAgent. That way we can future proof any deviation.
That being said, I think we can postpone creation of FulfillmentAgent at a later point too. @ravi-prakash-v @shenoyninad
Also there is a Billing schema. why is customer not same as Billing or Agent? Some rationalization may be in order. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not update the transaction.yaml file. Please update the schema file in the schemas folder and rebuild the transaction.yaml
@shenoyninad @venkatramanm can we create a discussion around the use case, arrive at an agreed upon schema, then raise an Issue (label: enhancement) linked to the discussion, then create a PR linked to that issue? Let us not have spec discussions on PRs. Or else PRs remain open for a long time. |
Makes sense |
Changes include
ref_id
property toorder_id