Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Customer and Support schema to add new properties #359

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Updating Customer and Support schema to add new properties #359

merged 2 commits into from
Jul 28, 2023

Conversation

shenoyninad
Copy link

@shenoyninad shenoyninad commented May 31, 2023

Changes include

  • Updating Customer schema to include an ID property that will be used to identify a customer
  • Updating Customer schema to include the organization property that is a reference to the Organization schema.
  • Updating the Support schema to modify the ref_id property to order_id

@shenoyninad shenoyninad changed the title Updating Customer schema to include Organization property Updating Customer and Support schema to add new properties May 31, 2023
@shenoyninad shenoyninad marked this pull request as ready for review May 31, 2023 16:30
@shenoyninad
Copy link
Author

Hi @ravi-prakash-v, I created a new PR. This has all the changes we discussed. Can you please take a look at it and approve it if everything looks good?

Copy link
Collaborator

@venkatramanm venkatramanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the Customer schema and Agent schema are the same except for being rateable and having a Rating. May be customer should also be rateable. I suggest we derive Customer from Agent.. FulfillmentAgent from Agent, Possibly fulfillment.agent could be of type FulfillmentAgent. That way we can future proof any deviation.

That being said, I think we can postpone creation of FulfillmentAgent at a later point too. @ravi-prakash-v @shenoyninad

@venkatramanm
Copy link
Collaborator

Also there is a Billing schema. why is customer not same as Billing or Agent? Some rationalization may be in order.

Copy link
Collaborator

@ravi-prakash-v ravi-prakash-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not update the transaction.yaml file. Please update the schema file in the schemas folder and rebuild the transaction.yaml

@ravi-prakash-v
Copy link
Collaborator

@shenoyninad @venkatramanm can we create a discussion around the use case, arrive at an agreed upon schema, then raise an Issue (label: enhancement) linked to the discussion, then create a PR linked to that issue? Let us not have spec discussions on PRs. Or else PRs remain open for a long time.

@venkatramanm
Copy link
Collaborator

Makes sense

@ravi-prakash-v ravi-prakash-v merged commit 431e316 into beckn:draft Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants