Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BLAKE-512 from auth header description #206

Merged
merged 21 commits into from
Feb 22, 2022

Conversation

BLR-0118
Copy link
Contributor

@ravi-prakash-v
Copy link
Collaborator

Can we add some content on how to generate the signing_string. Maybe a link to an RFC for Signing and Verification?

@BLR-0118
Copy link
Contributor Author

Can we add some content on how to generate the signing_string. Maybe a link to an RFC for Signing and Verification?

Is such an RFC available or can I link this doc?

@BLR-0118
Copy link
Contributor Author

If ok, I can have a markdown version of the doc created for signing and add to the RFCs?

@ravi-prakash-v
Copy link
Collaborator

@BLR-0118 That would be great

@BLR-0118
Copy link
Contributor Author

Added RFC for signing & verification - docs/protocol-drafts/BECKN-RFC-006-Signing-Beckn-APIs-In-HTTP-Draft-01.md

@ravi-prakash-v ravi-prakash-v self-requested a review January 27, 2022 11:42
...

**Request Body:**

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the code blocks using the "```" tags like this?

{
 "message": {
    "ack": {
        "status": "NACK"
    }
  }
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravi-prakash-v ravi-prakash-v merged commit e9a72d5 into beckn:core-0.9.4-draft Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants