Open Network Telemetry SDK(based on Open Network Telemetry Specifications v1.0) #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiva-rakshith
changed the title
shreyvishal
reviewed
Jul 26, 2024
| @@ -22,6 +22,7 @@ import { unConfigureActionHandler } from "../controllers/unconfigured.controller | |||
| import { LogLevelEnum } from "../utils/logger.utils"; | |||
|
|
|||
| export const requestsRouter = Router(); | |||
| import { onAPI } from "../utils/telemetry.utils"; | |||
There was a problem hiding this comment.
Is this onAPI function getting used in this file?
| @@ -16,6 +16,7 @@ import { AppMode } from "../schemas/configs/app.config.schema"; | |||
| import { GatewayMode } from "../schemas/configs/gateway.app.config.schema"; | |||
| import { getConfig } from "../utils/config.utils"; | |||
| import logger from "../utils/logger.utils"; | |||
| import { onAPI } from "../utils/telemetry.utils"; | |||
There was a problem hiding this comment.
Is this onAPI function getting used in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the telemetry based on Open Network Telemetry Specification v1.0(based on OTel Spec(https://opentelemetry.io/docs/specs/otel/)), which is a standardized telemetry specification for open, decentralized networks/protocols to enable network observability.
Open Network Telemetry Specifications v1.0: https://docs.google.com/document/d/1pG6nPQnR44EblckUmD6UdwJ5TrCjYQMjOdEBdNZ0V9I/edit#heading=h.jjzj6d1569a5
Open Network Telemetry SDK:
A JS SDK was built to generate the telemetry (https://github.com/Sunbird-Obsrv/open-network-telemetry). SDK Documentation: https://github.com/Sunbird-Obsrv/open-network-telemetry/blob/main/README.md
Protocol Server Changes:
Made changes in the protocol server by replacing old telemetry generation with new telemetry generation by SDK.