Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpate chunk/4 to chunk_every/4 #16

Merged
merged 6 commits into from
Oct 21, 2021

Conversation

davemenninger
Copy link

Fixes for #13

chunk/4 is deprecated. Replace with chunk_every/4.

chunk_every/2 and chunk_every/4 were introduced in Elixir 1.5, so this PR removes older versions from the Travis CI.

I've bumped the Elixir version up in mix.exs and bumped the package minor version up to 1.1.0 too.

@coveralls
Copy link

coveralls commented Jan 8, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 6ccda80 on davemenninger:chunk-every into 75788a6 on beatrichartz:master.

@davemenninger
Copy link
Author

davemenninger commented Jan 8, 2021

It seems like some of the tests based on timer pass/fail nondeterministically.

@davemenninger
Copy link
Author

I checked the downstream dependents: https://hex.pm/packages?search=depends%3Ahexpm%3Aparallel_stream

and some of them still support older versions of Elixir. How is this usually handled, requiring newer versions of Elixir? It seems like anything older than 1.6 isn't getting security patches anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants