-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add decode option to redact line sequence data from CSV #124
add decode option to redact line sequence data from CSV #124
Conversation
e372c08
to
af095a5
Compare
@beatrichartz you think you'll get a chance to look at this any time soon? |
@taylor-redden-papa thanks, functionality is looking good. There is a bunch of Elixir versions removed from CI, was there a reason for this or can we add them back? |
Hey, thanks for taking a look at it, I appreciate it. I can definitely add it back, but I was seeing this error when cicd was running: https://github.com/beatrichartz/csv/actions/runs/6115205079/job/16598348600
Not sure exactly why that happened, I hadn't see it on any pull requests recently. Give me a few and I'll change |
Ah I see dyalixir introduced a non-backwards compatible change. Can you lock it to version |
That works. Not sure whats up with coveralls. Made a comment coverage is still good, but the check didn't pass. |
Thanks, I'll release a new version some time this week! |
awesome, thanks so much! |
Ok this has been published in
|
This PR addresses
CSVs might contain sensitive data, so we could allow a decode option to not include that data as part of the exception messaging.
Open questions
It could be argued that this isn't needed at all and apps using this library could just not log this out when they get this exception. But for long standing apps, it might be easier for them to add this decode option in the few areas where they need to without changing any other telemetry or logging.
The naming from the option was inspired by the ecto field option
redact
. I thought this might be a similar situation.Checklist