Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

add support for quoted statuses #465

Merged
merged 1 commit into from
Apr 28, 2017
Merged

add support for quoted statuses #465

merged 1 commit into from
Apr 28, 2017

Conversation

jeremylow
Copy link
Collaborator

@jeremylow jeremylow commented Apr 11, 2017

Also adds corresponding class attributes for quoted_status_id and quoted_status_id_str. Fixes an overlooked issue with Status.__repr__() since the changes to character counting where self.text was None if the tweet was in extended mode, which meant the repr would show Text=None for all tweets.

Closes issues #421 and #428


This change is Reviewable

also adds corresponding class attributes for `quoted_status_id`
and `quoted_status_id_str`. Fixes an overlooked issue with
Status.__repr__() since the changes to character counting
where self.text was None if the tweet was in extended mode,
which meant the repr would show Text=None for all tweets.
@codecov-io
Copy link

Codecov Report

Merging #465 into master will increase coverage by 0.07%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   74.65%   74.73%   +0.07%     
==========================================
  Files           8        8              
  Lines        1953     1959       +6     
==========================================
+ Hits         1458     1464       +6     
  Misses        495      495
Impacted Files Coverage Δ
twitter/models.py 98.26% <83.33%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d39abd...c9e2827. Read the comment docs.

@jeremylow jeremylow requested a review from bear April 13, 2017 22:09
@jeremylow jeremylow merged commit 3d31088 into master Apr 28, 2017
@jeremylow jeremylow deleted the fix/issue421 branch April 28, 2017 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants