Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculation and disply for average of incomes and expenses #1619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vahidmah
Copy link
Contributor

This feature is calculating an average for incomes and expenses. I originally developed it for my own use but then thought of sharing it. Please check this PR and let me know what you think about it.

This is a screenshot using long-example

image

@vahidmah vahidmah force-pushed the feature/add-incomes-expenses-average branch from 94533e5 to 5b2ab98 Compare May 27, 2023 03:09
@yagebu
Copy link
Member

yagebu commented Jul 30, 2023

Hi, thank you for submitting the PR :) I think these averages are a useful bit of information but I find them to be a bit out of place. Since the account trees are for the whole time range and the charts show information per interval, maybe the average could be added to the chart instead (as part of the tooltip?)?

@vahidmah
Copy link
Contributor Author

Hi,
I wasn't quite certain about where to place this information. One possible location could be the tooltip of the chart. The challenge arises from the fact that the average is calculated for the entire duration (for the year 2014 in the given example), while hovering over a specific bar only displays data relevant to that particular interval (Jan 2014, below).

image

So, the question is, does this average value truly belong in the tooltip?

Maybe, another option could be incorporating a small summary section alongside the chart, where essential statistics like the average are showcased explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants