Add default_tax_rate to typespecs for Subscription and Invoice #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalexander
pushed a commit
to Frameio/stripity_stripe
that referenced
this pull request
Nov 20, 2024
…community#631) * Add optional default tax rates to subscription typespecs * Add optional default tax rates to invoice typespecs as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
default_subscription_rateskey as documented in the Stripe docs (see https://stripe.com/docs/api/subscriptions/create#create_subscription-default_tax_rates and https://stripe.com/docs/api/invoices/create#create_invoice-default_tax_rates) would work correctly, but would raise an error with dialyzer. This fixes that.