Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #519: Creating a card with cardholder as a cardholder struct throws #526

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

jcartwright
Copy link
Contributor

This corrects the typespecs to support Cardholder as a Stripe.id() or Cardholder.t() and casts to an id in both the Card create and Card update functions.

jcartwright and others added 2 commits July 30, 2019 11:10
- fixes beam-community#519: Creating a card with cardholder as a cardholder struct throws
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.024% when pulling 2b3fe7a on jcartwright:fix-card-cardholder into ced9aba on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snewcomer snewcomer merged commit 952664e into beam-community:master Jul 30, 2019
jcartwright added a commit to jcartwright/stripity_stripe that referenced this pull request Jul 30, 2019
jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 20, 2024
- fixes beam-community#519: Creating a card with cardholder as a cardholder struct throws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants