Add Stripe Issuing #493

jcartwright · 2019-05-09T14:30:05Z

Adding the Stripe Issuing objects:

Issuing.Authorization
Issuing.Card
Issuing.CardDetails
Issuing.Cardholder
Issuing.Dispute
Issuing.Transaction

https://stripe.com/docs/api/issuing/authorizations
https://raw.githubusercontent.com/stripe/openapi/master/openapi/spec3.yaml

coveralls · 2019-05-09T14:36:30Z

Coverage increased (+1.5%) to 87.055% when pulling 9e64940 on jcartwright:add-stripe-issuing into 7c54802 on code-corps:master.

jcartwright · 2019-05-09T16:38:33Z

@snewcomer here's my WIP merge request. I'm attempting to exercise the changes against the live API before I feel fully confident and would appreciate your eyes on the code as well.

jcartwright · 2019-05-09T21:38:19Z

I've exercised these changes against Stripe's test environment and things appear to work as expected. I think it's good to go.

- Issuing.Authorization - Issuing.Card - Issuing.CardDetails - Issuing.Cardholder - Issuing.Dispute - Issuing.Transaction

snewcomer · 2019-05-12T14:47:13Z

lib/stripe/types.ex

@@ -12,6 +12,30 @@ defmodule Stripe.Types do
          state: String.t() | nil
        }

+  @type authorization_controls :: %{


What if we inlined this in a Stripe.Issuing.Types module? Unless you see this type used outside the Issuing scope?.

Yeah, I noticed that pattern in some other instances. I'm happy to move the issuing-specific types into a separate module or inline them where appropriate.

Yeah that might be good if you don't mind

jcartwright · 2019-05-14T20:08:18Z

@snewcomer I've moved the issuing types around per your suggestion. Let me know if there's anything else you see that I can improve. Thanks.

jcartwright · 2019-05-21T15:47:20Z

@snewcomer any other feedback on this merge request? I'd love to get it merged before it gets stale.

snewcomer · 2019-05-21T21:55:27Z

@jcartwright Feel free to merge master and CI should be g2g!

jcartwright · 2019-05-21T22:05:05Z

@snewcomer CI seems to be failing CI to unformatted files outside of my merge request

stripity_stripe add-stripe-issuing % mix format --dry-run --check-formatted
** (Mix) mix format failed due to --check-formatted.
The following files were not formatted:

  * /Users/jcartwright/apps/stripity_stripe/lib/stripe/radar/review.ex
  * /Users/jcartwright/apps/stripity_stripe/test/stripe/converter_test.exs
  * /Users/jcartwright/apps/stripity_stripe/test/stripe/connect/transfer_reversal_test.exs
  * /Users/jcartwright/apps/stripity_stripe/test/stripe/subscriptions/usage_test.exs
  * /Users/jcartwright/apps/stripity_stripe/test/support/stripe_case.ex

Do you want me to format them in a separate MR?

lib/stripe/issuing/card.ex

snewcomer · 2019-05-21T22:53:15Z

lib/stripe/issuing/card_details.ex

+  """
+  @spec retrieve(Stripe.id() | Stripe.Issuing.Card.t(), Stripe.options()) ::
+          {:ok, t} | {:error, Stripe.Error.t()}
+  def retrieve(id, opts \\ []) do


Is this the same as the retrieve endpoint in Stripe.Issuing.Card? Is this module necessary?

CardDetails is a nested resource used to retrieve the full sensitive details for an issued card. I treated it like a separate and distinct resource because the struct is very different from the Card resource used to manage issued cards.

I see. In their example response, it looks like the response object contains most of what is in the Issuing.Card struct. Am I missing something?

https://stripe.com/docs/api/issuing/cards/retrieve_details

There is some overlap, but the CardDetails has a Card child object and then the sensitive attributes for :cvc and :number. I'm open to suggestions if it makes more sense to define the CardDetails struct and a retrieve_card_details function in the Card module. I see them as distinct structs but concede that it might be unnecessary to have a separate module.

@jcartwright Well I guess I am curious - if we limit the attributes to just these few, then won't we be discarding all of them that may come in the response?

All of the common attributes are in the CardDetails :card child element, so they are not discarded but simply nested.

- add required params on Card.create, Cardholder.create, and Dispute.create functions - add atom enums to typespecs and params

snewcomer

This looks really good! Lots of great work in here. 💯

jcartwright changed the title ~~WIP: Add Stripe Issuing~~ Add Stripe Issuing May 9, 2019

Add support for Stripe.Issuing

c4a9764

- Issuing.Authorization - Issuing.Card - Issuing.CardDetails - Issuing.Cardholder - Issuing.Dispute - Issuing.Transaction

jcartwright force-pushed the add-stripe-issuing branch from 989583d to c4a9764 Compare May 9, 2019 21:42

jcartwright mentioned this pull request May 10, 2019

Support for Stripe Issuing #489

Closed

snewcomer reviewed May 12, 2019

View reviewed changes

Jason Cartwright added 2 commits May 14, 2019 13:52

Move Issuing types inline or into separate module

7c58090

Move billing type to Issuing types

f03df46

Mix formatted

c9211bf

snewcomer assigned jcartwright May 21, 2019

snewcomer added 2.0 enhancement labels May 21, 2019

snewcomer reviewed May 21, 2019

View reviewed changes

lib/stripe/issuing/card.ex Show resolved Hide resolved

snewcomer reviewed May 21, 2019

View reviewed changes

Add required params

9e64940

- add required params on Card.create, Cardholder.create, and Dispute.create functions - add atom enums to typespecs and params

snewcomer approved these changes May 28, 2019

View reviewed changes

snewcomer merged commit d61b4bf into beam-community:master May 28, 2019

jcartwright deleted the add-stripe-issuing branch May 28, 2019 20:44

jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 19, 2024

Add Stripe Issuing (beam-community#493)

876aed9

jalexander pushed a commit to Frameio/stripity_stripe that referenced this pull request Nov 21, 2024

Add Stripe Issuing (beam-community#493)

843a4d1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Stripe Issuing #493

Add Stripe Issuing #493

jcartwright commented May 9, 2019 •

edited by snewcomer

Loading

coveralls commented May 9, 2019 •

edited

Loading

jcartwright commented May 9, 2019

jcartwright commented May 9, 2019

snewcomer May 12, 2019

jcartwright May 13, 2019

snewcomer May 14, 2019 •

edited

Loading

jcartwright commented May 14, 2019

jcartwright commented May 21, 2019

snewcomer commented May 21, 2019

jcartwright commented May 21, 2019

snewcomer May 21, 2019

jcartwright May 22, 2019

snewcomer May 23, 2019

jcartwright May 23, 2019 •

edited

Loading

snewcomer May 24, 2019

jcartwright May 24, 2019

snewcomer left a comment

Add Stripe Issuing #493

Add Stripe Issuing #493

Conversation

jcartwright commented May 9, 2019 • edited by snewcomer Loading

coveralls commented May 9, 2019 • edited Loading

jcartwright commented May 9, 2019

jcartwright commented May 9, 2019

snewcomer May 12, 2019

Choose a reason for hiding this comment

jcartwright May 13, 2019

Choose a reason for hiding this comment

snewcomer May 14, 2019 • edited Loading

Choose a reason for hiding this comment

jcartwright commented May 14, 2019

jcartwright commented May 21, 2019

snewcomer commented May 21, 2019

jcartwright commented May 21, 2019

snewcomer May 21, 2019

Choose a reason for hiding this comment

jcartwright May 22, 2019

Choose a reason for hiding this comment

snewcomer May 23, 2019

Choose a reason for hiding this comment

jcartwright May 23, 2019 • edited Loading

Choose a reason for hiding this comment

snewcomer May 24, 2019

Choose a reason for hiding this comment

jcartwright May 24, 2019

Choose a reason for hiding this comment

snewcomer left a comment

Choose a reason for hiding this comment

jcartwright commented May 9, 2019 •

edited by snewcomer

Loading

coveralls commented May 9, 2019 •

edited

Loading

snewcomer May 14, 2019 •

edited

Loading

jcartwright May 23, 2019 •

edited

Loading