-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CreditNote api calls #492
Add CreditNote api calls #492
Conversation
3 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One comment and I think if you merge master, the tests will pass.
@type t :: %__MODULE__{ | ||
id: Stripe.id(), | ||
object: String.t(), | ||
amount: number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be integer
or is number
valid as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch :) Pushed a new version
b5cb9e5
to
33c8ac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💳
See https://stripe.com/docs/api/credit_notes?lang=ruby
CreditNote were added to Stripe, I've added them in this PR following the open api spec.