Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elixir 1.8 to test matrix #449

Merged

Conversation

maartenvanvliet
Copy link
Member

Exclude elixir 1.8 from testing under otp 19.3 as it is not supported
(https://hexdocs.pm/elixir/compatibility-and-deprecations.html#compatibility-between-non-major-elixir-versions)

@coveralls
Copy link

coveralls commented Jan 16, 2019

Coverage Status

Coverage remained the same at 83.493% when pulling c3cbf38 on maartenvanvliet:test_with_elixir_1.8 into 4d2f943 on code-corps:master.

@maartenvanvliet
Copy link
Member Author

Looks like some dialyzer failures :(

@maartenvanvliet
Copy link
Member Author

Fixed by rebasing :)

@snewcomer
Copy link
Collaborator

@maartenvanvliet mind rebasing again? ANd then we will merge!! 🎉

@maartenvanvliet
Copy link
Member Author

Done 😀

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snewcomer snewcomer merged commit c2ef776 into beam-community:master Feb 6, 2019
@maartenvanvliet maartenvanvliet deleted the test_with_elixir_1.8 branch February 6, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants