add support for voiding invoices #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 similar comments
|
👍👏👍 |
ktravers
commented
Dec 27, 2018
| @@ -33,8 +33,7 @@ defmodule Stripe.SourceTest do | |||
|
|
|||
| describe "detach/2" do | |||
| test "detaches a source from a customer" do | |||
| assert {:ok, %{deleted: true, id: "src_123"}} = | |||
| Stripe.Source.detach("src_123", %{customer: "cus_123"}) | |||
| assert {:ok, %{id: "src_123"}} = Stripe.Source.detach("src_123", %{customer: "cus_123"}) | |||
There was a problem hiding this comment.
as of stripe-mock v0.39.0, this endpoint now returns a Stripe.Account object without a deleted attribute to match against.
i raised a ticket on stripe-mock, since based on Stripe API docs, it seems like this should respond with a Stripe.Source object instead... but regardless, the response will no longer contain a deleted attribute either way.
@snewcomer given that these changes are related to updating the stripe-mock version, not voiding an invoice, it seems cleaner to pull the version updates and this test change into a separate PR. let me know what you prefer.
jalexander
pushed a commit
to Frameio/stripity_stripe
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #429
HOLD pending #439
Stripe.Invoice#void/2function