Add Subscription and Invoice params #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
requested changes
Jul 13, 2018
| @@ -73,6 +79,7 @@ defmodule Stripe.Subscription do | |||
| :customer => Stripe.id() | Stripe.Customer.t(), | |||
| optional(:application_fee_percent) => integer, | |||
| optional(:billing) => String.t(), | |||
| optional(:billing_cycle_anchor) => Stripe.timestamp(), | |||
There was a problem hiding this comment.
Would you mind adding all 3 to the update spec as well?
There was a problem hiding this comment.
No problem! It's ready for another look.
| @@ -19,12 +19,15 @@ defmodule Stripe.Subscription do | |||
| id: Stripe.id(), | |||
| object: String.t(), | |||
| application_fee_percent: float | nil, | |||
| billing: String.t(), | |||
| billing_cycle_anchor: Stripe.timestamp(), | |||
| @@ -19,12 +19,15 @@ defmodule Stripe.Subscription do | |||
| id: Stripe.id(), | |||
| object: String.t(), | |||
| application_fee_percent: float | nil, | |||
| billing: String.t(), | |||
|
Thanks, and thank you for the awesome library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:billing,:billing_cycle_anchor, and:days_until_due(Closes Subscription Struct does not support billing, billing_cycle_anchor, and days_until_due #396):amount_paid,:amount_remaining,:auto_advance,:billing_reason,:hosted_invoice_url,:invoice_pdf,:number