Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update api version #351

Merged
merged 1 commit into from
May 18, 2018
Merged

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Apr 12, 2018

@coveralls
Copy link

coveralls commented Apr 12, 2018

Coverage Status

Coverage remained the same at 80.402% when pulling 8cb9a55 on snewcomer:update-api-version into 464687e on code-corps:2.0-beta.

@asonge
Copy link

asonge commented Apr 20, 2018

The code isn't compatible with the API version listed here, the code is compatible with the previous version.

@snewcomer
Copy link
Collaborator Author

@asonge Are you referring to the master branch or the 2.0.0-beta branch? I think the goal is to get the beta branch compat with the latest API version...

If it isn't compat with the beta branch, mind pointing out where the issue lies (sry still getting familiar with everything :) )?

@asonge
Copy link

asonge commented Apr 23, 2018

I haven't looked lately, but at the time, the beta branch was still a few months behind, particularly around some fields moving between objects on plans and products in February, but I could be wrong about this.

@snewcomer
Copy link
Collaborator Author

Ah yes that may have applied before. We are actively working on getting these resolved. Added Product and updated Plan specs recently. Also using this master of this branch on an active project.

I'm hoping to get #266 resolved in the next month or so.

https://github.com/code-corps/stripity_stripe/commits/2.0-beta

@snewcomer snewcomer added the 2.0 label May 4, 2018
@snewcomer snewcomer self-assigned this May 4, 2018
Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be good to go with this. If there are inconsistencies with the specified API version and the current behavior, we should open issues and resolve them.

@begedin begedin merged commit 771f0ab into beam-community:2.0-beta May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants