Fix upload file api #334
Merged
Fix upload file api #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjadczak
approved these changes
Jan 20, 2018
begedin
approved these changes
Jan 22, 2018
begedin
requested changes
Jan 22, 2018
lib/stripe/util.ex
Outdated
| @@ -65,6 +65,11 @@ defmodule Stripe.Util do | |||
| module |> Atom.to_string() |> String.trim_leading("Elixir.") | |||
| end | |||
|
|
|||
| def multipart_key(:file),do: :file | |||
| def multipart_key(key) when is_atom(key),do: Atom.to_string(key) | |||
| def multipart_key(key),do: key | |||
There was a problem hiding this comment.
Some formatting issues here
,do needs to be , do
lib/stripe/api.ex
Outdated
| { Stripe.Util.multipart_key(key), value} | ||
| end) | ||
|
|
||
| perform_request(req_url, :post, {:multipart, parts}, headers, opts ) |
There was a problem hiding this comment.
You got an extra space at the end here. opts ) -> opts)
lib/stripe/api.ex
Outdated
| |> add_auth_header(api_key) | ||
| |> add_connect_header(connect_account_id) | ||
| |> Map.to_list() | ||
| perform_request(req_url, method, req_body, headers, opts ) |
There was a problem hiding this comment.
Extra space here. opts ) -> opts)
lib/stripe/util.ex
Outdated
| def multipart_key(key) when is_atom(key),do: Atom.to_string(key) | ||
| def multipart_key(key),do: key | ||
|
|
||
|
|
There was a problem hiding this comment.
You can remove one of these blank lines here.
lib/stripe/api.ex
Outdated
| parts = | ||
| body | ||
| |> Enum.map(fn({key, value})-> | ||
| { Stripe.Util.multipart_key(key), value} |
There was a problem hiding this comment.
Extra space here: { Stripe.Util.multipart_key(key), value}-> {Stripe.Util.multipart_key(key), value}
lib/stripe/api.ex
Outdated
|
|
||
| @http_module.request(method, req_url, req_headers, req_body, req_opts) | ||
| |> handle_response() | ||
| perform_request(req_url, method, req_body, headers, opts ) |
|
@begedin Formatting applied 👍 |
begedin
requested changes
Jan 22, 2018
.gitignore
Outdated
| @@ -6,6 +6,8 @@ config/config.secret.exs | |||
| /doc | |||
| .DS_Store | |||
|
|
|||
| #elixir LS files | |||
| /.elixir_ls | |||
| # IntelliJ IDEA files | |||
There was a problem hiding this comment.
Sorry I missed this on the first passthrough, but more formatting issues here
- there should be a space in the comment:
#elixir LS files-># elixir LS files - there should be a blank line between lines 10 and 11
|
@begedin All formatting issues was addressed 👍 |
begedin
approved these changes
Apr 11, 2018
|
@chubarovNick Sorry for the delay on this. Merged. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.