-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport webhooks support #244
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
defmodule Stripe.Webhook do | ||
@moduledoc """ | ||
Creates an event from webhook's payload if signature is valid. | ||
|
||
Use `construct_event/3` to verify the authenticity of a webhook request and | ||
convert its payload into a map representing the event. | ||
|
||
case Stripe.Webhook.construct_event(payload, signature, secret) do | ||
{:ok, event} -> | ||
# Return 200 to Stripe and handle event | ||
{:error, reason} -> | ||
# Reject webhook by responding with non-2XX | ||
end | ||
""" | ||
@default_tolerance 300 | ||
@expected_scheme "v1" | ||
|
||
def construct_event(payload, signature_header, secret, tolerance \\ @default_tolerance) do | ||
case verify_header(payload, signature_header, secret, tolerance) do | ||
:ok -> | ||
{:ok, Stripe.Util.string_map_to_atoms(Poison.decode!(payload))} | ||
error -> | ||
error | ||
end | ||
end | ||
|
||
defp verify_header(payload, signature_header, secret, tolerance) do | ||
case get_timestamp_and_signatures(signature_header, @expected_scheme) do | ||
{nil, _} -> | ||
{:error, "Unable to extract timestamp and signatures from header"} | ||
|
||
{_, []} -> | ||
{:error, "No signatures found with expected scheme #{@expected_scheme}"} | ||
|
||
{timestamp, signatures} -> | ||
with {:ok, timestamp} <- check_timestamp(timestamp, tolerance), | ||
{:ok, _signatures} <- check_signatures(signatures, timestamp, payload, secret) do | ||
:ok | ||
else | ||
{:error, error} -> {:error, error} | ||
end | ||
end | ||
end | ||
|
||
defp get_timestamp_and_signatures(signature_header, scheme) do | ||
signature_header | ||
|> String.split(",") | ||
|> Enum.map(& String.split(&1, "=")) | ||
|> Enum.reduce({nil, []}, fn | ||
["t", timestamp], {nil, signatures} -> | ||
{to_integer(timestamp), signatures} | ||
|
||
[^scheme, signature], {timestamp, signatures} -> | ||
{timestamp, [signature | signatures]} | ||
|
||
_, acc -> | ||
acc | ||
end) | ||
end | ||
|
||
defp to_integer(timestamp) do | ||
case Integer.parse(timestamp) do | ||
{timestamp, _} -> | ||
timestamp | ||
:error -> | ||
nil | ||
end | ||
end | ||
|
||
defp check_timestamp(timestamp, tolerance) do | ||
now = System.system_time(:seconds) | ||
if timestamp < (now - tolerance) do | ||
{:error, "Timestamp outside the tolerance zone (#{now})"} | ||
else | ||
{:ok, timestamp} | ||
end | ||
end | ||
|
||
defp check_signatures(signatures, timestamp, payload, secret) do | ||
signed_payload = "#{timestamp}.#{payload}" | ||
expected_signature = compute_signature(signed_payload, secret) | ||
if Enum.any?(signatures, & secure_equals?(&1, expected_signature)) do | ||
{:ok, signatures} | ||
else | ||
{:error, "No signatures found matching the expected signature for payload"} | ||
end | ||
end | ||
|
||
defp compute_signature(payload, secret) do | ||
:crypto.hmac(:sha256, secret, payload) | ||
|> Base.encode16(case: :lower) | ||
end | ||
|
||
defp secure_equals?(input, expected) when byte_size(input) == byte_size(expected) do | ||
input = String.to_charlist(input) | ||
expected = String.to_charlist(expected) | ||
secure_compare(input, expected) | ||
end | ||
defp secure_equals?(_, _), do: false | ||
|
||
defp secure_compare(acc \\ 0, input, expected) | ||
defp secure_compare(acc, [], []), do: acc == 0 | ||
defp secure_compare(acc, [input_codepoint | input], [expected_codepoint | expected]) do | ||
import Bitwise | ||
acc | ||
|> bor(input_codepoint ^^^ expected_codepoint) | ||
|> secure_compare(input, expected) | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
defmodule Stripe.WebhookTest do | ||
use ExUnit.Case | ||
|
||
import Stripe.Webhook | ||
|
||
@valid_payload ~S({"object": "event"}) | ||
@invalid_payload "{}" | ||
|
||
@valid_scheme "v1" | ||
@invalid_scheme "v0" | ||
|
||
@secret "secret" | ||
|
||
defp generate_signature(timestamp, payload, secret \\ @secret) do | ||
:crypto.hmac(:sha256, secret, "#{timestamp}.#{payload}") | ||
|> Base.encode16(case: :lower) | ||
end | ||
|
||
defp create_signature_header(timestamp, scheme, signature) do | ||
"t=#{timestamp},#{scheme}=#{signature}" | ||
end | ||
|
||
test "payload with a valid signature should return event" do | ||
timestamp = System.system_time(:seconds) | ||
payload = @valid_payload | ||
signature = generate_signature(timestamp, payload) | ||
signature_header = create_signature_header(timestamp, @valid_scheme, signature) | ||
|
||
assert {:ok, _event} = construct_event(payload, signature_header, @secret) | ||
end | ||
|
||
test "payload with an invalid signature should fail" do | ||
timestamp = System.system_time(:seconds) | ||
payload = @valid_payload | ||
signature = generate_signature(timestamp, "random") | ||
signature_header = create_signature_header(timestamp, @valid_scheme, signature) | ||
|
||
assert {:error, _message} = construct_event(payload, signature_header, @secret) | ||
end | ||
|
||
test "payload with wrong secret should fail" do | ||
timestamp = System.system_time(:seconds) | ||
payload = @valid_payload | ||
signature = generate_signature(timestamp, payload, "wrong") | ||
signature_header = create_signature_header(timestamp, @valid_scheme, signature) | ||
|
||
assert {:error, _message} = construct_event(payload, signature_header, @secret) | ||
end | ||
|
||
test "payload with missing signature scheme should fail" do | ||
timestamp = System.system_time(:seconds) | ||
payload = @valid_payload | ||
signature = generate_signature(timestamp, payload) | ||
signature_header = create_signature_header(timestamp, @invalid_scheme, signature) | ||
|
||
assert {:error, _message} = construct_event(payload, signature_header, @secret) | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike my comment in #239, the master branch does not have a
%Stripe.Event{}
, so the only thing to do here is to update the comments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, comments fixed.