fix: remove param casting to atom (#807)

beam-community · Oct 4, 2023 · bac80fa · bac80fa
1 parent 067653d
commit bac80fa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/stripe/error.ex b/lib/stripe/error.ex
@@ -100,7 +100,7 @@ defmodule Stripe.Error do
           extra: %{
             optional(:card_code) => card_error_code,
             optional(:decline_code) => String.t(),
-            optional(:param) => atom,
+            optional(:param) => String.t(),
             optional(:charge_id) => Stripe.id(),
             optional(:http_status) => 400..599,
             optional(:raw_error) => map,
@@ -164,7 +164,7 @@ defmodule Stripe.Error do
           %{raw_error: error_data, http_status: status}
           |> maybe_put(:card_code, error_data |> Map.get("code") |> maybe_to_atom())
           |> maybe_put(:decline_code, error_data |> Map.get("decline_code"))
-          |> maybe_put(:param, error_data |> Map.get("param") |> maybe_to_atom())
+          |> maybe_put(:param, Map.get(error_data, "param"))
           |> maybe_put(:charge_id, error_data |> Map.get("charge"))
 
         %__MODULE__{

diff --git a/test/stripe/error_test.exs b/test/stripe/error_test.exs
@@ -29,7 +29,7 @@ defmodule Stripe.ErrorTest do
       error = Error.from_stripe_error(400, error_data, "id")
       assert error.code == :invalid_request_error
       assert error.extra.http_status == 400
-      assert error.extra.param == :type
+      assert error.extra.param == "type"
       assert error.extra.raw_error == error_data
       assert error.message == "Received unknown parameter: type"
       assert error.request_id == "id"