This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Prompt to save #1198
Merged
Prompt to save #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching up with upstream
Fixed an issue that emerged when implementing this. I don't believe when downloading an `.html` page that we'd want the browser toolbar to open. The one with Downloads, History, etc. If we do want that to open, we can easily update this pull request to allow that.
pfrazee
suggested changes
Oct 8, 2018
|
Ye sorry, my vs code formats in save. I need to turn that off. I'll revert the format changes ASAP. Do you have a format file in the code, I'll look when I get home in 15mins or so. In regards to the |
|
@Septimus okay can you comment on the .html suppression explaining that? Regarding the code formatting, I updated the |
Fixed an issue that emerged when implementing this. I don't believe when downloading an `.html` page that we'd want the browser toolbar to open. The one with Downloads, History, etc. If we do want that to open, we can easily update this pull request to allow that.
This reverts commit c88459a.
|
👍 Looks great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a prompt when using
CTRLorCMD + Son an HTML page. It grabs the page title as a default for file saving, but still gives you the option to update the filename and save path.