Change param name for API consistency

beakerbrowser · Nov 16, 2020 · aa1b6aa · aa1b6aa
1 parent 47cf8ff
commit aa1b6aa
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/app/bg/web-apis/bg/contacts.js b/app/bg/web-apis/bg/contacts.js
@@ -45,7 +45,7 @@ export default {
    * @returns {Promise<Array<BeakerContactPublicAPIContactRecord>>}
    */
   async requestContacts () {
-    var urls = await shellAPI.selectDriveDialog.call(this, {tag: 'contact', multiple: true, writable: false})
+    var urls = await shellAPI.selectDriveDialog.call(this, {tag: 'contact', allowMultiple: true, writable: false})
     let infos = await Promise.all(urls.map(url => (
       drives.getDriveInfo(url, {ignoreCache: false, onlyCache: true}).catch(e => ({}))
     )))

diff --git a/app/bg/web-apis/bg/shell.js b/app/bg/web-apis/bg/shell.js
@@ -134,7 +134,7 @@ export default {
    * @param {string} [opts.buttonLabel]
    * @param {boolean} [opts.writable]
    * @param {string} [opts.tag]
-   * @param {boolean} [opts.multiple]
+   * @param {boolean} [opts.allowMultiple]
    * @returns {Promise<string|string[]>}
    */
   async selectDriveDialog (opts = {}) {
@@ -144,7 +144,7 @@ export default {
     assert(!opts.buttonLabel || typeof opts.buttonLabel === 'string', '.buttonLabel must be a string')
     assert(!opts.tag || typeof opts.tag === 'string', '.tag must be a string')
     assert(!opts.writable || typeof opts.writable === 'boolean', '.writable must be a boolean')
-    assert(!opts.multiple || typeof opts.multiple === 'boolean', '.multiple must be a boolean')
+    assert(!opts.allowMultiple || typeof opts.allowMultiple === 'boolean', '.allowMultiple must be a boolean')
 
     // initiate the modal
     var res

diff --git a/app/fg/modals/select-drive.js b/app/fg/modals/select-drive.js
@@ -164,7 +164,7 @@ class SelectDriveModal extends LitElement {
     this.buttonLabel = 'Select'
     this.tag = null
     this.writable = undefined
-    this.multiple = undefined
+    this.allowMultiple = undefined
     this.cbs = null
   }
 
@@ -174,7 +174,7 @@ class SelectDriveModal extends LitElement {
     this.buttonLabel = params.buttonLabel || 'Select'
     this.tag = params.tag
     this.writable = params.writable
-    this.multiple = params.multiple
+    this.allowMultiple = params.allowMultiple
     await this.requestUpdate()
     this.adjustHeight()
 
@@ -219,7 +219,7 @@ class SelectDriveModal extends LitElement {
 
           <div class="form-actions">
             <div class="left">
-              ${this.writable !== false && !this.multiple ? html`
+              ${this.writable !== false && !this.allowMultiple ? html`
                 <button type="button" @click=${this.onClickCreate} data-content="newdrive" class="btn">
                   Create new drive
                 </button>
@@ -301,7 +301,7 @@ class SelectDriveModal extends LitElement {
 
   onChangeSelecteddrive (e) {
     var url = e.currentTarget.dataset.url
-    if (this.multiple) {
+    if (this.allowMultiple) {
       if (this.selection.includes(url)) {
         this.selection = this.selection.filter(u => u !== url)
       } else {
@@ -330,14 +330,14 @@ class SelectDriveModal extends LitElement {
   onSubmit (e) {
     if (e) e.preventDefault()
     if (this.selection.length) {
-      if (this.multiple) {
+      if (this.allowMultiple) {
         this.cbs.resolve({urls: this.selection})
       } else {
         this.cbs.resolve({url: this.selection[0]})
       }
     } else {
       let url = (new URL(this.currentTitleFilter)).origin
-      if (this.multiple) {
+      if (this.allowMultiple) {
         this.cbs.resolve({urls: [url]})
       } else {
         this.cbs.resolve({url})