Skip to content

Commit

Permalink
net/tipc: initialize security state for new connection socket
Browse files Browse the repository at this point in the history
Calling connect() with an AF_TIPC socket would trigger a series
of error messages from SELinux along the lines of:
SELinux: Invalid class 0
type=AVC msg=audit(1434126658.487:34500): avc:  denied  { <unprintable> }
  for pid=292 comm="kworker/u16:5" scontext=system_u:system_r:kernel_t:s0
  tcontext=system_u:object_r:unlabeled_t:s0 tclass=<unprintable>
  permissive=0

This was due to a failure to initialize the security state of the new
connection sock by the tipc code, leaving it with junk in the security
class field and an unlabeled secid.  Add a call to security_sk_clone()
to inherit the security state from the parent socket.

Reported-by: Tim Shearer <[email protected]>
Signed-off-by: Stephen Smalley <[email protected]>
Acked-by: Paul Moore <[email protected]>
Acked-by: Ying Xue <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
stephensmalley authored and davem330 committed Jul 8, 2015
1 parent 4df48e8 commit fdd75ea
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/tipc/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -2007,6 +2007,7 @@ static int tipc_accept(struct socket *sock, struct socket *new_sock, int flags)
res = tipc_sk_create(sock_net(sock->sk), new_sock, 0, 1);
if (res)
goto exit;
security_sk_clone(sock->sk, new_sock->sk);

new_sk = new_sock->sk;
new_tsock = tipc_sk(new_sk);
Expand Down

0 comments on commit fdd75ea

Please sign in to comment.