feat: show callout admin button for reviewers #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpf500
changed the title
JumpLink
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the admin interface for callouts visible in the menu for callout reviewers.
For speed it's fairly hardcoded right now, I've added
GetCalloutWith.IsReviewerwhich adds anisReviewerflag to the API response. I did consider a more generic approach, e.g.GetCalloutWith.Permissions, that could be extended in the future, but in the end this didn't seem worth the additional complexity.This code would still be relatively easy to refactor into something more general in the future, once those requirements are more well defined.