Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move webhooks to separate app #83

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Conversation

wpf500
Copy link
Member

@wpf500 wpf500 commented Nov 18, 2024

This PR moves the webhook app into it's own app, part of the ongoing work to split the backend app up.

Most changes relate to updating the import in the tools as the runApp helper has been moved to @beabee/core. These tools will be moved to their own app soon.

The only other significant change is to the Dockerfile. I've just moved the file to a common location and modified it to build different parts of the backend. A cleaner way would be to unify backend and frontend Docker builds with a common base image (as in #4), but this way is a clean way to share the backend build configuration without more major changes.

Note: #82 should be merged first

@wpf500 wpf500 marked this pull request as ready for review November 18, 2024 14:42
Copy link
Collaborator

@JumpLink JumpLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a great approach, but I also think that the Dockerfile should be its own NPM package.

I think in the future this repo should also be part of the workspace if we found a clean way for that: https://github.com/beabee-communityrm/hive-deploy-stack and this repo contains not only the docker-compose.yml but also scripts, so it makes sense if it is its own package that can be executed together during the build process and for the Dockerfile it should also be so that it is consistent.

Base automatically changed from refactor/share-backend-config to main November 20, 2024 15:08
@wpf500 wpf500 merged commit a00dca1 into main Nov 21, 2024
9 checks passed
@wpf500 wpf500 deleted the refactor/split-webhooks branch November 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants