-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(contact-tagging): Add support tagable contacts with bulk action #63
Conversation
… -> tag/ToggleTagButton.vue
…ate the old tags to the new structure
@wpf500 I initially based my implementation on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments but in general this is really great 🎉. Well on it's way to being one of those magical PRs that adds a feature with a negative line count 😄
…w contact tag structure
I was very happy to do so, I found it difficult to understand (and I still haven't fully understood it) but the tidying up and documenting helped me to do so, so it wasn't entirely self-serving ;) |
…out responses unified
…instead + removed old tags prop in contact profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but generally looks really great 🎉
One other question: have you tested the migration against an instance that had old style tags to migrate? Did it work on dev for example? |
Yes you can look at this on dev, the old tags have been successfully preserved |
…Manager without a selection
With my lastest changes I have implemented:
|
Contact Tagging System Implementation
Description
This PR implements a comprehensive contact tagging system by aligning it with the existing Callout Responses tag functionality. The changes include:
Key Changes
Testing Checklist
Tag Management
Filtering & Pagination
Integration Tests
UI Components
Related Components
Translations Checklist