Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: simplify Docker builds #6

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

wpf500
Copy link
Member

@wpf500 wpf500 commented Jul 4, 2024

This is my attempt to understand and simplify the new Docker builds in the monorepo. It also fixes the problem that the .dockerignore files were being ignored (haha), as it needs to be in the root of the context.

Mostly it reduces the number of lines needed to add the common package and removes as much context specific knowledge as possible.

@JumpLink
Copy link
Collaborator

JumpLink commented Jul 5, 2024

@wpf500 It's good to know that the .dockerignore simply has to be placed in the root / where the context is. It can then be kept general enough to be used for all docker images. To do this, it would make sense to align the structure of the packages so that, for example, they all use the output path dist. For the backend, it is still built on main (I changed this in my PR with the same goal, but the .dockerignore files are still duplicated and would need to be removed in the package / app pathes)

@wpf500 wpf500 merged commit d088dab into main Jul 8, 2024
7 checks passed
@wpf500 wpf500 deleted the build/simplify-dockerfiles branch July 8, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants