Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Upgrade dependencies #3

Merged
merged 15 commits into from
Jun 5, 2024
Merged

Conversation

JumpLink
Copy link
Collaborator

@JumpLink JumpLink commented May 31, 2024

Changes

Omitted upgrades

  • gulp from 4 to 5: This is needed for the legacy frontend, which is to be removed anyway. In addition, not all plugins have been updated to 5 yet.
  • eslint from 8 to 9: To much work atm, maybe we can just take over a good config like this.

What I tested

  • Clicked around a bit and saw if it looked good
  • Create callout
  • Answer callout
  • The callout content WYSIWYG Editor
  • Contribution changed

TODO

  • Check SASS Backend

Problems

Sometimes there was a hiccup, but then it calmed down again. I don't know what exactly happened here, e.g.:

2024-06-04 11:09:33 node:internal/modules/cjs/loader:1456
2024-06-04 11:09:33     throw err;
2024-06-04 11:09:33     ^
2024-06-04 11:09:33 
2024-06-04 11:09:33 SyntaxError: /opt/apps/backend/built/core/defaults.json: Unexpected end of JSON input
2024-06-04 11:09:33     at parse (<anonymous>)
2024-06-04 11:09:33     at Module._extensions..json (node:internal/modules/cjs/loader:1453:39)
2024-06-04 11:09:33     at Module.load (node:internal/modules/cjs/loader:1207:32)
2024-06-04 11:09:33     at Module._load (node:internal/modules/cjs/loader:1023:12)
2024-06-04 11:09:33     at Module.require (node:internal/modules/cjs/loader:1235:19)
2024-06-04 11:09:33     at require (node:internal/modules/helpers:176:18)
2024-06-04 11:09:33     at Object.<anonymous> (/opt/apps/backend/src/core/services/OptionsService.ts:2:1)
2024-06-04 11:09:33     at Module._compile (node:internal/modules/cjs/loader:1376:14)
2024-06-04 11:09:33     at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
2024-06-04 11:09:33     at Module.load (node:internal/modules/cjs/loader:1207:32)

When I restarted the container, the error had disappeared. I don't think this has anything to do with the upgrade, since all that is being imported here is a JSON.

Base automatically changed from improve-build-speed to main June 4, 2024 06:34
@JumpLink JumpLink requested a review from wpf500 June 4, 2024 13:10
@JumpLink JumpLink merged commit 30e21c2 into main Jun 5, 2024
18 checks passed
@JumpLink JumpLink deleted the upgrade-dependencies branch June 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant