feat: enable Sales tax #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpf500
force-pushed
the
feat/enable-tax-rate
branch
from
4d35cd6
to
0dc2ba8
Compare
wpf500
force-pushed
the
feat/enable-tax-rate
branch
from
20e058f
to
0cfe9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable sales tax. For simplicity, this PR makes the Stripe tax rate code a bit less generic so it only deals with sales tax stuff.
Instead of batch updating all the subscriptions in one go, just update them when they create their next invoice. This avoids needing any sort of batch job management. It uses the
invoice.createdwebhook to update the draft invoice, and also update the subscription.This PR also improves the documentation a bit by formatting some comments into JSDoc