Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

feat(tax-rate): Add tax rate note to join form #587

Merged
merged 8 commits into from
May 10, 2024
Merged

feat(tax-rate): Add tax rate note to join form #587

merged 8 commits into from
May 10, 2024

Conversation

JumpLink
Copy link
Contributor

@JumpLink JumpLink commented Apr 25, 2024

Title

Add tax rate note to join form and update contribution pages

Describe your changes

  • Add the HTML / Vue code to src/components/pages/join/JoinForm.vue .
  • Add the HTML / Vue code to src/components/pages/profile/contribution/UpdateContribution.vue .
  • Add translations for English and German

Screenshots

image

Checklist before requesting a review

  • Done a self-review of my code
  • Run npm run check and addressed any problems
  • PR doesn't have merge conflicts
  • Tax note should be not visible if tax is disabled

Checklist before merging

  • Translations for all new i18n strings

@JumpLink JumpLink requested a review from wpf500 April 25, 2024 10:17
@wpf500
Copy link
Member

wpf500 commented Apr 25, 2024

🎉

I've updated the English translation, could you rerun npm run i18n?

Base automatically changed from feat/set-tax-rate to main May 10, 2024 08:28
@wpf500
Copy link
Member

wpf500 commented May 10, 2024

Waiting for some translations then this can be merged

@wpf500 wpf500 merged commit a947677 into main May 10, 2024
4 checks passed
@wpf500 wpf500 deleted the feat/join-tax branch May 10, 2024 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants