Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

feat(tax-rate)!: Add tax rate #575

Merged
merged 18 commits into from
May 10, 2024
Merged

feat(tax-rate)!: Add tax rate #575

merged 18 commits into from
May 10, 2024

Conversation

JumpLink
Copy link
Contributor

@JumpLink JumpLink commented Apr 16, 2024

Add the tax rate to the frontend

grafik

Backend: beabee-communityrm/beabee#397

@JumpLink JumpLink requested a review from wpf500 April 17, 2024 08:19
Copy link
Member

@wpf500 wpf500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the tax rate setting from the membership builder into the settings? It can just go here under a new heading ("Payment"?)

image

@JumpLink
Copy link
Contributor Author

Can you move the tax rate setting from the membership builder into the settings? It can just go here under a new heading ("Payment"?)

sure

@JumpLink
Copy link
Contributor Author

@wpf500 I have moved the tax settings to the general settings page on this branch. I think now the data should also be stored there in the database and no longer in join content, or what do you think?

@JumpLink JumpLink changed the title feat(tax-rate): Add tax rate to membership builder feat(tax-rate)!: Add tax rate Apr 24, 2024
Copy link
Member

@wpf500 wpf500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR doesn't add the tax rate to the join form right? Just the admin side?

src/pages/admin/settings/index.vue Outdated Show resolved Hide resolved
src/pages/admin/settings/index.vue Outdated Show resolved Hide resolved
@JumpLink
Copy link
Contributor Author

I think this PR doesn't add the tax rate to the join form right? Just the admin side?

Yes, I think the join part can be implemented together with new UX design, or should I add the tax also to the current to be able to ship this without the new join UX flow?

@JumpLink JumpLink requested a review from wpf500 April 24, 2024 18:55
@wpf500 wpf500 merged commit 3b02246 into main May 10, 2024
4 checks passed
@wpf500 wpf500 deleted the feat/set-tax-rate branch May 10, 2024 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants