This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add filtering by callout response for contacts #574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JumpLink
approved these changes
Apr 26, 2024
JumpLink
suggested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, only the import of the styles should be changed
Closing in favour of beabee-communityrm/monorepo#5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the frontend support for filtering contacts by their answers to callouts, the related backend changes are in beabee-communityrm/beabee#392.
AppSearch*
components have been refactored to support dynamic filters. In this particular use case the filters are dependent on the callout the admin wants to filter by, when they choose a callout it loads the answer filters for that callout.To support this filter groups can now define a custom component which handles rendering filter rules instead of the default component
AppSearchRuleFilterGroup
. SeeCalloutResponseFilterGroup
for how this is implemented for callout response filtering.This PR also includes the following changes:
*Added
type="button"
toAppToggle
to stop it trying to submit formsAppSearch
by moving most of the logic into newAppSearchForm
andAppSearchSummary
components which handle the form and summary views respectivelyFilterGroup.items
used to be astring[]
of filter item IDs, now it is the actual list of filter items. This simplifies the component logic as there's no need to pass bothfilterGroups
andfilterItems
to the components. The methodwithItem
gives developers a type-safe way to define filters for a given model.The PR introduces a cleaner layout for filter groups, separating them out into "tabs" instead of optgroups
Before:
After: