Make install of Java optional #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 9, 2015 11:18
bdwyertech
added a commit
that referenced
this pull request
Oct 21, 2015
Make install of Java optional
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java cookbook recommends allowing users to skip this cookbook:
https://github.com/agileorbit-cookbooks/java#allow-people-to-not-use-this-cookbook
This adds
java_installattribute that gives them this option.This shouldn't impact
default['wildfly']['java']['enforce_java_home']logic. It might be nice to allow a user to define java home via an attribute, but I will leave that up to how you would like to manage this.Thanks,
Dennis