Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SetACL from 3.0.6 to 3.1.2 fixing #309 #310

Conversation

jpluimers
Copy link

@jpluimers jpluimers commented Oct 6, 2022

Updates .nuspec (version) and install script (download URL and sha256)

fixes #309

slycordinator and others added 9 commits March 13, 2022 18:27
* Added array variables for file types to be used in different phases
* Modified BinaryExtensions array to be on multiple lines for easier readability
* Changed code syntax to make order consistent
Updates .nuspect (version) and install script (download URL and sha256)
@jpluimers jpluimers changed the title Upgrade SetACL from 3.0.6 to 3.1.2 fixing #306 Upgrade SetACL from 3.0.6 to 3.1.2 fixing #309 Oct 6, 2022
@aetonsi
Copy link

aetonsi commented Jan 13, 2023

Hi @bcurran3, any timeline about the possible merging of this? And thanks @jpluimers, hope you're doing well

@bcurran3
Copy link
Owner

Repo is finally sync fixed!

Not sure why choco-cleaner files are mixed in with this... possibly from "fixing" the repo?

If this is still current and you pull out the CC stuff, I'll probably pull it in this weekend. Sorry for the delay.

@aetonsi
Copy link

aetonsi commented Apr 30, 2023

If this is still current

v3.1.2 is still the latest version if that's what you're asking

somehow merged in when repo "fixed"
@bcurran3
Copy link
Owner

Can you pull the choco-cleaner stuff from the PR please? I tried, not sure I did it right.

Copy link
Owner

@bcurran3 bcurran3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove choco-cleaner/tools/choco-cleaner.ps1 from the PR

@bcurran3
Copy link
Owner

bcurran3 commented May 8, 2023

Ironically I updated the package back in Oct 2022 but never pushed it.

nuspec needed more updating to fix markdown issues, add release notes and other things.
install script needed more updating as there are 32bit and 64bit versions of the program and shimgen would make a shim for each; first overwriting the 2nd. So if you're on a 32bit machine the shim wouldn't work since it was pointing to the 64bit version. I now autogenerate an .ignore file for the non-appropriate file during install.

Pushed new version.
choco install setacl --version=3.1.2.86

@bcurran3 bcurran3 closed this May 8, 2023
@aetonsi
Copy link

aetonsi commented May 10, 2023

Hi, just out of curiosity, how long does it take for chocolatey to make a new version (3.1.2 in this case) the "main" one?
Or will it always be necessary to specify --version=xxx to upgrade?

@bcurran3
Copy link
Owner

Until a package has been updated at least 3 times with no problems, it has to go through human moderation. That moderation can take a few days to a month depending on how big the queue is and the time availability of the volunteers that do it.

@aetonsi
Copy link

aetonsi commented May 12, 2023

Oh ok i see, thanks for the info. Cool to know.

@jpluimers
Copy link
Author

Hi @bcurran3, any timeline about the possible merging of this? And thanks @jpluimers, hope you're doing well

Thanks. I'm still alive and doing OK. Will post an update to the original issue shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to upgrade SetACL to the new version?
4 participants