Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old memdb with level-mem #29

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Replace old memdb with level-mem #29

merged 1 commit into from
Oct 13, 2019

Conversation

vweevers
Copy link
Contributor

@vweevers vweevers commented Oct 13, 2019 •
edited
Loading

Same API, but up to date.

vweevers
vweevers commented Oct 13, 2019
View reviewed changes
test/hooks.js Outdated Show resolved Hide resolved
@vweevers
Copy link
Contributor Author

Build failure is due to Travis having an outdated npm cache.

bcomnes
bcomnes approved these changes Oct 13, 2019
View reviewed changes
Copy link
Owner

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vweevers ! Tests are passing

@bcomnes bcomnes merged commit ee5b0b6 into bcomnes:master Oct 13, 2019
@vweevers vweevers deleted the level-mem branch October 13, 2019 15:17
@vweevers
Copy link
Contributor Author

@bcomnes I forgot to mention, subleveldown will likely stop working with memdb. In case you're using this combination of modules anywhere else.

@bcomnes
Copy link
Owner

bcomnes commented Oct 13, 2019

@vweevers Is there anything I can read about that to understand the issue and potential solutions?

@vweevers vweevers mentioned this pull request Oct 13, 2019
Closed
@vweevers
Copy link
Contributor Author

Level/subleveldown#83

@bcomnes
Copy link
Owner

bcomnes commented Oct 13, 2019 •
edited
Loading

Thanks will check that out

@bcomnes
Copy link
Owner

bcomnes commented Oct 14, 2019

Apologies, I read this in reverse, that level-mem is dropping support for subleveldown or something. Everything looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes bcomnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vweevers @bcomnes