Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable the babel/nyc cache #303

Merged
merged 3 commits into from
Jul 8, 2016
Merged

fix: disable the babel/nyc cache #303

merged 3 commits into from
Jul 8, 2016

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Jul 7, 2016

the interactions between the ava, babel, and nyc cache were causing a lot of confusion for folks, see:

#296
#294

In this pull request:

  • we leave nyc's cache as opt in (I was considering making it run by default in 7.x).
  • we disable babel's cache when running tests with nyc (this cache caused a lot of issues with babel-plugin-istanbul).

@bcoe
Copy link
Member Author

bcoe commented Jul 7, 2016

@jamestalmage, @JaKXz, @gotwarlost, @kentcdodds mind giving the release candidate 7.0.0-alpha.5 a spin, adds:

  • @jamestalmage's fixes for pid collisions.
  • fixes for babel cache (which was making babel-plugin-istanbul/__coverage__ hard to use).
  • instrument command for instrumenting files outside the context of tests.

If everyone signs off, I'd like to push this to next soon -- back-peddled a bit on the first release because of various issues opened around caching.

@JaKXz
Copy link
Member

JaKXz commented Jul 7, 2016

@bcoe works for me 👍 [on OS X]

@kentcdodds
Copy link
Member

nyc@next is working great for me too!

@bcoe bcoe merged commit 104b3da into master Jul 8, 2016
@bcoe bcoe deleted the uncache branch July 8, 2016 07:04
@gotwarlost
Copy link
Collaborator

sorry for not responding. I was on a flight from India and dealing with jet lag later. Sounds like it's rocking now! I'll give it a whirl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants